fix a bug in watch loading, watch syncing, and watch syncing summary #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
added
the
ready-to-merge
pchiusano
approved these changes
May 7, 2021
|
Weird, it's the same type of error I had seen before but had vaguely gone away. I'll try to get to the bottom of it. |
mergify
bot
removed
the
ready-to-merge
|
Oops, the test passed and it auto-merged before I'd gotten to the bottom of it. I didn't expect it to merge because one of the tests was failing for me locally. I don't have a deterministic test for two different errors. |
aryairani
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1916 in
SqliteCodebase.hsand anelemvsnotElembug in skipping watch results that already exist at the destination during sync inSync22.hs.