Skip to content

Fix bug that would cause scopes to be improperly reported in EasyTest #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2021

Conversation

pchiusano
Copy link
Member

Fixes #1860

I had to test this manually since there's not currently a combinator to check that a test fails with a particular scope. It would be pretty easy to add but I didn't have time now.

@pchiusano pchiusano requested a review from aryairani May 25, 2021 17:38
Copy link
Contributor

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@aryairani aryairani merged commit fbd1ab6 into trunk May 25, 2021
@aryairani aryairani deleted the fix/1860 branch May 25, 2021 23:02
@pchiusano pchiusano mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix off-by-one scope reporting for exceptions caught by EasyTest
2 participants