Fix bad failure references in builtins #2033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When originally written, various builtins were referencing data types defined in IOSource. However, those no longer exist there. - Instead, they are defined in Unison.Builtin.Decls - This switches the builtins to the Decls values, some of which weren't exported yet. - Also eliminates them from IOSource, since the ones there didn't actually work. - Transcript testing the behavior added.
pchiusano
added
the
ready-to-merge
pchiusano
approved these changes
May 27, 2021
|
Hmm, the exact error message depends on OS, and that ends up in the transcript output. |
|
@dolio you can match on the failure and just strip out the message
|
|
Looks great, mergin'! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defined in IOSource. However, those no longer exist there.
exported yet.
actually work.
Fixes #2027, inasmuch as it now gives a proper failure condition.