Testing harness for round-trip parsing/pretty-printing testing #2385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runarorama
approved these changes
Sep 7, 2021
runarorama
added
the
ready-to-merge
It now runs the test but doesn't care if the output has changed
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work with @runarorama. This PR makes a tweak to how the transcript parser works so that the
loadcommand can pick up what was dumped to the scratch file via theeditcommand. Specifically, it clears the transcript file cache after eachucmstanza.This is a bit hacky, but we thought fine for now--and it turns out no existing transcripts were relying on the transcript file cache sticking around across multiple
ucmstanzas.It also adds a transcript demonstrating how new round-trip tests can be added easily.