Fix emphasis roundtrip in docs #2427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchiusano
approved these changes
Sep 22, 2021
* Allow ~~ to contain ~ * Make ** bold and __ italic
runarorama
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2408
This changes the lexer and pretty-printer for doc literals slightly. Underscores are now allowed inside emphasis elements surrounded by
__, as long as there are strictly fewer_inside than around.When pretty-printing, we print as many
_as necessary so that it's one more than the longest run of_inside the element.Same for
**and~~and''.This also changes the meaning of
*and_so that now any number of*means "bold" and any number of_means "italic".