Replace assert with assertThat in tests #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdas
reviewed
Jul 2, 2024
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| import java.util.List; | |||
|
|
|||
| import static org.assertj.core.api.Assertions.assertThat; | |||
| import static org.junit.Assert.*; | |||
There was a problem hiding this comment.
do we need these imports any more?
There was a problem hiding this comment.
yeah those are still used across tests until Junit4 assertions are switched to AssertJ assertions
tdas
reviewed
Jul 2, 2024
| assertThat(resp.getNextPageToken()).isNotNull(); | ||
| assertThat(resp.getTables()).hasSize(1) | ||
| .first() | ||
| .usingRecursiveComparison() |
There was a problem hiding this comment.
this seems to be a change in the test logic. @ravivj-db could you double check this?
There was a problem hiding this comment.
this is because previously the assert wasn't executed and the condition was actually never met (the single element in the list was never equal to the expectation due to tiny differences in the fields that were excluded here)
tdas
approved these changes
Jul 4, 2024
|
@nastra Thank you very much for the fixes and improvements! |
ravivj-db
pushed a commit
to ravivj-db/unitycatalog
that referenced
this pull request
Jul 5, 2024
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** The `assert` keyboard in Java needs to be explicitly enabled (via `-ea`), otherwise it doesn't do anything and gets optimized away. There are also a few `assert` usages in web service code and those should be replaced either with `Preconditions.checkNotNull` or with a Validation API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
The
assertkeyboard in Java needs to be explicitly enabled (via-ea), otherwise it doesn't do anything and gets optimized away. There are also a fewassertusages in web service code and those should be replaced either withPreconditions.checkNotNullor with a Validation API