[FOLLOW-UP] Format Spark Integration code by javafmtAll #291
Conversation
|
I also tried to run |
|
Can you just leave the description of the changes alone? 🙏 Makes git log so terrible to look at 😢 |
| override def listTables(namespace: Array[String]): Array[Identifier] = ??? | ||
| override def listTables(namespace: Array[String]): Array[Identifier] = { | ||
| if (namespace.length > 1) { | ||
| throw new ApiException("Unity Catalog does not support nested namespace.") |
There was a problem hiding this comment.
- "nested namespaces" (plural)
- Can you add what the
namespaceis in the exception
Nested namespaces are not supported: [namespace]
| if (namespace.length > 1) { | ||
| throw new ApiException("Unity Catalog does not support nested namespace.") | ||
| } | ||
| val response: ListTablesResponse = tablesApi.listTables(this.name, namespace.head, 0, null) |
There was a problem hiding this comment.
What do you think about introducing local variables with names for the input arguments, i.e. catalogName, schemaName, maxResults and pageToken? Java doesn't support named arguments unfortunately. I think it would make code comprehension a bit better (unless you're in IntelliJ IDEA and gets all this for free 😉 )
A bit weird to see null among the input arguments, isn't it?
There was a problem hiding this comment.
ah I see. Sure done. This seems to be more readable.
|
connectors/spark/src/test/java/io/unitycatalog/connectors/spark/CredentialTestFileSystem.java
Show resolved
Hide resolved
|
This is hard to review because it also changes the indentation. Please don't do so as this project does not share the same code style standard with Apache Spark. |
@cloud-fan the main page documentation says to format the code by |
amaliujia
changed the title
Description of changes
[FOLLOW-UP] Format Spark Integration code by javafmtAll.