removed checkstyle import order configuration #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Jul 31, 2024
haogang
approved these changes
Aug 1, 2024
kevinzwang
pushed a commit
to kevinzwang/unitycatalog
that referenced
this pull request
Oct 10, 2024
**PR Checklist** - [x ] A description of the changes is added to the description of this PR. - [x ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** <!-- Please state what you've changed and how it might affect the users. --> Removed the checkstyle configuration that related to the order and line space for import statements in the java code. This was different to the order enforced by javafmt see: unitycatalog#98 also some discussion here: unitycatalog#289 Signed-off-by: Kevin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Removed the checkstyle configuration that related to the order and line space for import statements in the java code. This was different to the order enforced by javafmt
see: #98
also some discussion here: #289