Skip to content

Conversation

FreeMem17
Copy link
Contributor

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

  • Documentation change only
  • Add a page for integration of Unity Catalog and PuppyGraph

@FreeMem17 FreeMem17 requested a review from MrPowers as a code owner August 19, 2024 08:39
Copy link
Collaborator

@michelleon michelleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennyglee to take a look

other than the one change in the header it looks good to me

@FreeMem17 FreeMem17 requested a review from michelleon August 19, 2024 18:18
Copy link
Contributor

@dennyglee dennyglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A non-blocking suggestion would be to add some screenshots to PuppyGraph UI to the docs as well. But this should be done in a different PR.

@FreeMem17
Copy link
Contributor Author

FreeMem17 commented Aug 20, 2024

This looks great! A non-blocking suggestion would be to add some screenshots to PuppyGraph UI to the docs as well. But this should be done in a different PR.

Thank you @dennyglee. I will add them in a separate PR. Is there a general recommendation on image dimension / file size?

@dennyglee dennyglee dismissed michelleon’s stale review August 20, 2024 22:52

Change was made per request

@dennyglee dennyglee merged commit 146972d into unitycatalog:main Aug 20, 2024
4 checks passed
@dennyglee
Copy link
Contributor

This looks great! A non-blocking suggestion would be to add some screenshots to PuppyGraph UI to the docs as well. But this should be done in a different PR.

Thank you @dennyglee. I will add them in a separate PR. Is there a general recommendation on image dimension / file size?

Oh sorry for missing this, GitHub has a max size of 10MB but I would recommend it to be smaller closer to GitHub's Social Media Preview. HTH!

kevinzwang pushed a commit to kevinzwang/unitycatalog that referenced this pull request Oct 10, 2024
**PR Checklist**

- [x] A description of the changes is added to the description of this
PR.
- [x] If there is a related issue, make sure it is linked to this PR.
- [x] If you've fixed a bug or added code that should be tested, add
tests!
- [x] If you've added or modified a feature, documentation in `docs` is
updated

**Description of changes**

<!-- Please state what you've changed and how it might affect the users.
-->
- Documentation change only
- Add a page for integration of  Unity Catalog and PuppyGraph

Signed-off-by: Kevin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants