-
Notifications
You must be signed in to change notification settings - Fork 509
Docs: Add a PuppyGraph Integration Guide #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add a PuppyGraph Integration Guide #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennyglee to take a look
other than the one change in the header it looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! A non-blocking suggestion would be to add some screenshots to PuppyGraph UI to the docs as well. But this should be done in a different PR.
Thank you @dennyglee. I will add them in a separate PR. Is there a general recommendation on image dimension / file size? |
Oh sorry for missing this, GitHub has a max size of 10MB but I would recommend it to be smaller closer to GitHub's Social Media Preview. HTH! |
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [x] If there is a related issue, make sure it is linked to this PR. - [x] If you've fixed a bug or added code that should be tested, add tests! - [x] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** <!-- Please state what you've changed and how it might affect the users. --> - Documentation change only - Add a page for integration of Unity Catalog and PuppyGraph Signed-off-by: Kevin Wang <[email protected]>
PR Checklist
docs
is updatedDescription of changes