-
Notifications
You must be signed in to change notification settings - Fork 509
0.2.1 UI features #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jamieknight-db
merged 4 commits into
unitycatalog:branch-0.2
from
jamieknight-db:0.2.1-ui-features
Oct 8, 2024
Merged
0.2.1 UI features #573
jamieknight-db
merged 4 commits into
unitycatalog:branch-0.2
from
jamieknight-db:0.2.1-ui-features
Oct 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Ability to delete a model version from the UI. <img width="425" alt="Screenshot 2024-09-26 at 2 29 57 PM" src="https://github.com/user-attachments/assets/fb27e047-f642-4221-8ef2-3b5ea96091a5"> <img width="522" alt="Screenshot 2024-09-26 at 2 29 51 PM" src="https://github.com/user-attachments/assets/d3b83207-3b21-44c5-8089-04d5370c3118"> <img width="226" alt="Screenshot 2024-09-26 at 2 29 41 PM" src="https://github.com/user-attachments/assets/b4726f0e-b5ad-4ac5-a1b6-77c9a3aba815"> (cherry picked from commit a4382c6)
**PR Checklist** - [ X] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Users can delete models from the UI. <img width="427" alt="Screenshot 2024-09-30 at 12 33 30 PM" src="https://github.com/user-attachments/assets/1729869b-8260-4dcb-b290-55c223f862ac"> <img width="522" alt="Screenshot 2024-09-30 at 12 33 24 PM" src="https://github.com/user-attachments/assets/87238db6-c5c7-42d1-99a1-90c8b323e248"> <img width="519" alt="Screenshot 2024-09-30 at 12 32 48 PM" src="https://github.com/user-attachments/assets/cbde51b3-b82f-4527-8105-926cd283b1bf"> <img width="180" alt="Screenshot 2024-09-30 at 12 32 37 PM" src="https://github.com/user-attachments/assets/2a506f2c-f396-473a-bded-a5720b06698b"> (cherry picked from commit 45001a6)
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** User can update model version description via the UI. <img width="422" alt="Screenshot 2024-10-01 at 5 07 00 PM" src="https://github.com/user-attachments/assets/72519f61-0105-42b9-bea2-71987bfebce2"> <img width="440" alt="Screenshot 2024-10-01 at 5 06 40 PM" src="https://github.com/user-attachments/assets/e8edd838-8871-473b-be45-00bf47cf04db"> <img width="523" alt="Screenshot 2024-10-01 at 5 06 35 PM" src="https://github.com/user-attachments/assets/edfaf5e6-bd26-4e53-8e34-c9eb46ec3d83"> <img width="379" alt="Screenshot 2024-10-01 at 5 06 12 PM" src="https://github.com/user-attachments/assets/7349da70-cc8e-447b-acd3-3c205ab7fd02"> (cherry picked from commit 00cbefb)
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** User can add/edit model description via the UI. <img width="532" alt="Screenshot 2024-10-03 at 1 28 41 PM" src="https://github.com/user-attachments/assets/ae2222ec-f426-4cd4-96b9-ab41f317c985"> <img width="261" alt="Screenshot 2024-10-03 at 1 28 14 PM" src="https://github.com/user-attachments/assets/d2b5d701-6b1e-4075-a3df-d7d4fbc95851"> <img width="411" alt="Screenshot 2024-10-03 at 1 28 06 PM" src="https://github.com/user-attachments/assets/39329596-272f-4469-9533-ff7aa595a988"> <img width="516" alt="Screenshot 2024-10-03 at 1 28 01 PM" src="https://github.com/user-attachments/assets/2170fa3b-b1a6-4d57-af7a-9d6e83f7bd2d"> <img width="355" alt="Screenshot 2024-10-03 at 1 27 47 PM" src="https://github.com/user-attachments/assets/3bb567cc-020e-4aa5-a2b9-695b744a7a8f"> (cherry picked from commit 60b27c5)
creechy
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Looks like four previous PRs w/o any merge conflicts.
xx-db
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes