Skip to content

fix: syncMode - default: use append strategy when using dev serve… #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: syncMode - default: use append strategy when using dev serve… #887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c6f4cb
fix: syncMode - `default`: use `append` strategy when using dev serve…
xiaweiss Sep 26, 2025
51daa76
Merge branch 'main' into sync-mode
xiaweiss Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/core/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class Context {
this.options = resolveOptions(rawOptions, this.root)
this.sourcemap = rawOptions.sourcemap ?? true
this.generateDeclaration = throttle(500, this._generateDeclaration.bind(this), { noLeading: false })
this._removeUnused = this.options.syncMode === 'overwrite'
this._removeUnused = this.options.syncMode !== 'append'

if (this.options.dumpComponentsInfo) {
const dumpComponentsInfo = this.options.dumpComponentsInfo === true
Expand Down Expand Up @@ -80,13 +80,13 @@ export class Context {
return

this._server = server
this._removeUnused = this.options.syncMode !== 'append'
this._removeUnused = this.options.syncMode === 'overwrite'
this.setupWatcher(server.watcher)
}

setupWatcher(watcher: fs.FSWatcher) {
const { globs } = this.options

this._removeUnused = this.options.syncMode === 'overwrite'
watcher
.on('unlink', (path) => {
if (!matchGlobs(path, globs))
Expand All @@ -112,7 +112,7 @@ export class Context {
*/
setupWatcherWebpack(watcher: fs.FSWatcher, emitUpdate: (path: string, type: 'unlink' | 'add') => void) {
const { globs } = this.options

this._removeUnused = this.options.syncMode === 'overwrite'
watcher
.on('unlink', (path) => {
if (!matchGlobs(path, globs))
Expand Down