Improve the ios1() and iso2() date parsers
#183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuankunzhang
force-pushed
the
improve-date-module
branch
2 times, most recently
from
1a003d2 to
416508e
Compare
- Add `TryFrom<(&str, u32, u32)>` implementation for `Date` struct with validation. - Add comprehensive date validation for months, days, taking leap year into account. - Refactor `iso1()` and `iso2()` date parsers to use the new validation logic.
yuankunzhang
force-pushed
the
improve-date-module
branch
from
416508e to
7478659
Compare
yuankunzhang
changed the title
ios1() and iso2() date parsers
cakebaker
reviewed
Jul 21, 2025
Co-authored-by: Daniel Hofstetter <[email protected]>
cakebaker
reviewed
Jul 21, 2025
cakebaker
reviewed
Jul 21, 2025
Co-authored-by: Daniel Hofstetter <[email protected]>
|
Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryFrom<(&str, u32, u32)>implementation forDatestruct with validation.iso1()andiso2()date parsers to use the new validation logic.It now supports arbitrary length of year-string, month-string, and day-string, as long as they are valid values. For example:
000098-002-003or0000980203.