-
Notifications
You must be signed in to change notification settings - Fork 31
add a new from_str_at_date(date, string) function #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 70.54% 71.47% +0.92%
==========================================
Files 2 2
Lines 275 312 +37
Branches 66 75 +9
==========================================
+ Hits 194 223 +29
Misses 39 39
- Partials 42 50 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2002c69
to
f24b5ed
Compare
AFAIK, not needed for coreutils (yet?) but an interesting features |
Co-authored-by: Daniel Hofstetter <[email protected]>
Co-authored-by: Daniel Hofstetter <[email protected]>
Co-authored-by: Daniel Hofstetter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit an unusual approach to delegate from from_str_at_date
to from_str
instead of the other way around I expected to see before starting the review.
(jiff series #2) refactor: optimize time type sizes and add conversion from `Time` to `jiff::civil::Time`
No description provided.