Skip to content

Conversation

sylvestre
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2 (5c9e485) into main (1f0eae3) will increase coverage by 0.92%.
The diff coverage is 67.39%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   70.54%   71.47%   +0.92%     
==========================================
  Files           2        2              
  Lines         275      312      +37     
  Branches       66       75       +9     
==========================================
+ Hits          194      223      +29     
  Misses         39       39              
- Partials       42       50       +8     
Flag Coverage Δ
macos_latest 71.47% <67.39%> (+0.92%) ⬆️
ubuntu_latest 71.47% <67.39%> (+0.92%) ⬆️
windows_latest 71.47% <67.39%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/simple.rs 75.86% <65.00%> (-2.49%) ⬇️
src/lib.rs 68.87% <69.23%> (+2.58%) ⬆️

@sylvestre
Copy link
Contributor Author

AFAIK, not needed for coreutils (yet?) but an interesting features

sylvestre and others added 2 commits May 11, 2023 16:47
Co-authored-by: Daniel Hofstetter <[email protected]>
Co-authored-by: Daniel Hofstetter <[email protected]>
Copy link
Collaborator

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit an unusual approach to delegate from from_str_at_date to from_str instead of the other way around I expected to see before starting the review.

@sylvestre sylvestre merged commit db00d06 into uutils:main May 11, 2023
@sylvestre sylvestre deleted the from_str_at_date branch May 11, 2023 15:16
cakebaker added a commit that referenced this pull request Aug 16, 2025
(jiff series #2) refactor: optimize time type sizes and add conversion from `Time` to `jiff::civil::Time`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants