refactor: replace imperative parsing loop with functional combinators #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuankunzhang
force-pushed
the
parser-combinators
branch
from
3cb500c to
54e5a8b
Compare
cakebaker
reviewed
Sep 15, 2025
cakebaker
reviewed
Sep 15, 2025
- Add `TryFrom<Vec<Items>>` implementation for `DateTimeBuilder` to improve code separation and reusability. - Replace manual parsing loop in `parse_items()` with `repeat_until` combinator for cleaner approach. - Allow timestamp strings ending with whitespaces.
yuankunzhang
force-pushed
the
parser-combinators
branch
from
54e5a8b to
2dc4fa3
Compare
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryFrom<Vec<Items>>implementation forDateTimeBuilderto improve code separation and reusability.parse_items()withrepeat_untilcombinator for cleaner approach.