forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 67
Closed
Description
/cc @fhinkel @matthewloring @hashseed @targos
The vee-eight-lkgr
branch has a version of Node.js master from more than 2 months ago. I am going to use this issue to rebase to the latest master along with pickup the V8 ToT from this morning.
I am going to reset the head to what I have on my fork presently, specfically 1735fdf. Since rebase is destructive on the history, I have created a backup tag lkgr-backup-20170214
pointing the to present head: 9e76b83.
A few tests are still disabled in this branch. Most of these are related to debug.
Issues that need to be addressed as a follow-on:
Debug::SetMessageHandler
is a nop in V8 5.8. This means thatnode debug
can no longer work. All the test usingnode debug
should be migrated to usenode inspect
instead. I tried doing this, but was blocked by a bug thatnode --inspect-port=${port}
doesn't seem to be getting propagated to the inferior. All instances of thenode inspect
inferior start on the same (default) port, causing grief. For now I have deleted the debug tests, but as a follow on these should be properly fixed.test-intl-no-icu-data.js
is a new test. I didn't have time to look into why it is failing.- I am not sure if the windows build issues have been addressed yet.
Metadata
Metadata
Assignees
Labels
No labels