Skip to content

Docs/dashboard style updates #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2025
Merged

Conversation

rolfsmeds
Copy link
Contributor

Dashboard docs updates for vaadin/web-components#8962

Copy link

github-actions bot commented May 7, 2025

AI Language Review

In the JavaScript TypeScript code:

  1. In dashboard-basic and dashboard-dense-layout components, the updated version uses --vaadin-dashboard-widget-rowspan and --vaadin-dashboard-widget-colspan instead of --vaadin-dashboard-item-rowspan and --vaadin-dashboard-item-colspan. Ensure this change is intentional and consistent with any associated updates in vaadin-dashboard API.

  2. In the Styling AsciiDoc file, under the "Style Variants" section, ensure consistency with any related components or themes in the vaadin-dashboard API if applicable.

No major issues, just ensure compatibility with these changes in the broader application context.

@rolfsmeds rolfsmeds requested a review from jouni May 19, 2025 11:24
@ugur-vaadin ugur-vaadin force-pushed the docs/dashboard-style-updates branch from 3d4a848 to a86db94 Compare May 22, 2025 10:24
@ugur-vaadin ugur-vaadin merged commit 5d7dc25 into latest May 22, 2025
4 of 5 checks passed
@ugur-vaadin ugur-vaadin deleted the docs/dashboard-style-updates branch May 22, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants