Skip to content

feat: message-list markdown support #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented May 8, 2025

Description

Add markdown support to <vaadin-message-list>

Fixes #8697
Related to vaadin/platform#7601

Type of change

Feature

@tomivirkki tomivirkki requested review from sissbruecker and vursen May 8, 2025 08:20
Copy link

sonarqubecloud bot commented May 8, 2025

/**
* When set to `true`, the message text is parsed as Markdown.
*/
markdown: boolean | undefined;
Copy link
Contributor

@knoobie knoobie May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Instead of markdown boolean - what would you think about a property / enum mode (or format) allowing to switch between mode=text (default), mode=markdown or html or any other thing you guys might come up with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option was discussed during API design. We ended up with a markdown flag due to simplicity and because markdown also allows html content.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also discussed later adding some kind of a renderer API which would allow you to decide how an item text gets rendered inside the message. That's not included in the current scope though.

@tomivirkki tomivirkki merged commit df7e517 into main May 8, 2025
9 checks passed
@tomivirkki tomivirkki deleted the feat/message-list-markdown branch May 8, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageList to support Markdown syntax
3 participants