fix: adjust virtualizer indexes when scrolling at the end #9142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ugur-vaadin
commented
May 16, 2025
| @@ -231,9 +231,13 @@ describe('virtualizer - scrollbar scrolling', () => { | |||
| // Sanity check for iron-list internal properties | |||
| const adapter = virtualizer.__adapter; | |||
| const firstItem = adapter._physicalItems[adapter._physicalStart]; | |||
| expect(firstItem.__virtualIndex).to.equal(adapter._virtualStart); | |||
| expect(firstItem.__virtualIndex).to.closeTo(adapter._virtualStart, 10); | |||
There was a problem hiding this comment.
Indexes can go out of sync temporarily while scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The indexes in the virtualizer are not properly updated when
This case is not properly handled in the iron list core or the adapter. The result is the items not being properly rendered and some loops occurring based on resize timing.
This PR adapts the index adjustment on large jump logic in the iron list core
_scrollHandlerto the adapter override so that the rows are rendered correctly.Before fix:
withoutFix.mov
After fix:
withFix.mov
Fixes #7307
Type of change
Checklist