experiment: add select base styles and visual tests #9189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
experiment/select-base-styles
branch
2 times, most recently
from
151e746 to
2b80e86
Compare
web-padawan
force-pushed
the
experiment/select-base-styles
branch
from
2b80e86 to
03d76ff
Compare
|
Will update to use cursor custom CSS properties once #9190 is merged. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
vaadin-selectbase styles and visual tests from thebase-stylesbranch.This also includes base styles for
vaadin-overlaywhich will be used by other components too.Note: I decided to preserve
vaadin-overlay-styles.jsfile to avoid changing imports for it everywhere.The actual
overlayStylesthat it provides will still be correctly resolved to base styles in visual tests.UPD: two adjustments for
vaadin-select-value-buttonstyles:pointer-events: nonefor disabled state to avoid focusing select when it is disabled.Type of change