forked from gorilla/mux
-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
code-qualityImprove code qualityImprove code qualitydev-expDeveloper experienceDeveloper experiencefeatureFeature request is when an idea for completely new feature is submittedFeature request is when an idea for completely new feature is submittedgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededshellShell related code changes (required/expected)Shell related code changes (required/expected)todoHas TODOs to create indicidual issues fromHas TODOs to create indicidual issues from
Description
Is your feature request related to a problem? Please describe.
Currently, we only check coverage in local run with manual validation. Need to automate for CI/CD.
Describe the solution you'd like
Need a script that will fail if the expected threshold is not met. This can then be run from GitHub actions on every push or PR.
Describe alternatives you've considered
Make
target would also do the trick. But as the commands grow in size, it gets a hassle to overload makefile.
Additional context
- GitHub actions already have the unit test run workflow(s). Just need to add a separate workflow of coverage check.
- If using a script, it should run on
bash
(zsh
user myself, I still thinkbash
is the standard). Syntax differences of different shells or WSL is a headache of the future developers.
Ownership of Contribution
If the triage is approved,
- I wish to submit the PR myself.
- I wish to submit the PR. But if someone is willing to do it, go ahead.
- I don't know how to fix this or make these changes. I wish others to pick this up for me.
Metadata
Metadata
Assignees
Labels
code-qualityImprove code qualityImprove code qualitydev-expDeveloper experienceDeveloper experiencefeatureFeature request is when an idea for completely new feature is submittedFeature request is when an idea for completely new feature is submittedgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededshellShell related code changes (required/expected)Shell related code changes (required/expected)todoHas TODOs to create indicidual issues fromHas TODOs to create indicidual issues from