add value to operator configmap for enabling/disabling analytics

[dminnear-rh]

No description provided.

[mhjacks]

Philosophical question: double negatives can be really confusing as config values (look at Ansible's "no_log"). Would it be better to have analytics.enabled and default it to true here? It would be the same net effect. I'm definitely open to counter-arguments on this point, especially if there's some awkwardness in go casting or something like that.

[mbaldessari]

Is the env variable approach via the subscription (https://github.com/validatedpatterns/patterns-operator/blob/main/cmd/main.go#L106) not enough? (It was placed there at the Hoff's request so I was wondering ;) )

[dminnear-rh]

@mbaldessari We discussed using that env var (and I leave the capability intact in this PR) but it does come across as obfuscated to control it via config attached to the subscription and it may be problematic with OLM v1. Using the configmap for the operator seems like a more obvious way to configure it.

To @mhjacks 's point, I will update the configmap to use analytics.enabled = true which is also a bit clearer than the analytics.disabled = false logic this PR has at the moment.

[mbaldessari]

/approve

[mbaldessari]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dminnear-rh, mbaldessari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mbaldessari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment