Skip to content

Updates for Azure machinesets #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

Updates for Azure machinesets #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9760e1
Updates for Azure machinesets
mlabonte-rh Aug 1, 2025
f747568
Fix linting errors
mlabonte-rh Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions tests/interop/test_validate_gpu_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ def test_validate_gpu_nodes(openshift_dyn_client):
found = False
for machineset in machinesets:
logger.info(machineset.instance.metadata.name)
if re.search("gpu", machineset.instance.metadata.name):
# "gpu" for AWS machineset
# "nvidia" for Azure machineset
if re.search("gpu", machineset.instance.metadata.name) or re.search(
"nvidia", machineset.instance.metadata.name
):
gpu_machineset = machineset
found = True
break
Expand Down Expand Up @@ -86,18 +90,20 @@ def test_validate_gpu_nodes(openshift_dyn_client):
logger.info("Checking GPU machineset instance type")

err_msg = "No instanceType found for GPU machineset"
try:
logger.info(
machineset.instance.spec.template.spec.providerSpec.value.instanceType
)
except AttributeError:
logger.error(f"FAIL: {err_msg}")
assert False, err_msg

instance_type = str(
machineset.instance.spec.template.spec.providerSpec.value.instanceType
# for AWS
instance_type = (
gpu_machineset.instance.spec.template.spec.providerSpec.value.instanceType
)
if instance_type == "None":
if instance_type is None:
# for Azure
instance_type = (
gpu_machineset.instance.spec.template.spec.providerSpec.value.vmSize
)

logger.info(instance_type)

if instance_type is None:
logger.error(f"FAIL: {err_msg}")
assert False, err_msg

Expand Down