Skip to content

Conversation

rak810
Copy link
Contributor

@rak810 rak810 commented May 27, 2021

  • feat(isAlpha, isAlphanumeric): Added support for Bengali language
  • Made some changes in alpha.js according to npm test results
  • Written tests for Bengali language features in isAlpha and is Alpha

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1678 (74ea0fb) into master (3873ebf) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 74ea0fb differs from pull request most recent head c7c0760. Consider uploading reports for the commit c7c0760 to get more accurate results

@@            Coverage Diff             @@
##            master     #1678    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          104       101     -3     
  Lines         2120      1860   -260     
  Branches       475         0   -475     
==========================================
- Hits          2120      1860   -260     
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <100.00%> (ø)
src/index.js 100.00% <0.00%> (ø)
src/lib/isIP.js 100.00% <0.00%> (ø)
src/lib/isIn.js 100.00% <0.00%> (ø)
src/lib/trim.js 100.00% <0.00%> (ø)
src/lib/isBIC.js 100.00% <0.00%> (ø)
src/lib/isEAN.js 100.00% <0.00%> (ø)
src/lib/isHSL.js 100.00% <0.00%> (ø)
src/lib/isInt.js 100.00% <0.00%> (ø)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3873ebf...c7c0760. Read the comment docs.

profnandaa
profnandaa previously approved these changes Jul 16, 2021
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉
/cc. @ezkemboi @tux-tn -- please have a second look.

tux-tn
tux-tn previously requested changes Jan 28, 2022
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rak810 Can you please fix merge conflicts?

@tux-tn tux-tn added mc-to-land Just merge-conflict standing between the PR and landing. 🧹 needs-update For PRs that need to be updated before landing labels Jan 28, 2022
@rubiin rubiin dismissed tux-tn’s stale review July 19, 2022 17:07

addressed

@rubiin rubiin merged commit 35b5ffb into validatorjs:master Jul 19, 2022
@WikiRik WikiRik mentioned this pull request Aug 10, 2022
3 tasks
pano9000 pushed a commit to pano9000/validator.js that referenced this pull request Dec 5, 2022
Added in validatorjs#1678 without specific reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing. needs-more-review 🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants