fix: Modify pattern of pt-Br regex #1951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A Brazilian cellphone number can start with 1 after its country code and local code - Fix test case to accept +55 11 91431-4567 and similar ones as valid Signed-off-by: Matheus Gomes <[email protected]>
matheusnascgomes
force-pushed
the
fix/isMobilePhoneRegex_ptBr
branch
from
86e48a2 to
06f9919
Compare
Codecov Report
@@ Coverage Diff @@
## master #1951 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2085 2085
Branches 472 472
=========================================
Hits 2085 2085
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Apr 24, 2022
tux-tn
added
ready-to-land
|
Hi @tux-tn ! Any plans on merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brazilian cellphone number can start with "1" after its country code and local code
Checklist