Skip to content

Conversation

ademyan05
Copy link
Contributor

fixed the syntax of arrays in the Readme, as some were missing commas and single quotations.

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1987 (8b564ae) into master (cfcf911) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1987   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...8b564ae. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you @ademyan05

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Jun 24, 2022
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really keen eye! Thanks for the fix 🎉

@profnandaa
Copy link
Member

@ademyan05 -- can fix the m/c or I can do it in a bulk PR too.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Jun 30, 2022
@rubiin
Copy link
Member

rubiin commented Jul 27, 2022

@ademyan05 MR needs fixing

@pano9000
Copy link
Contributor

FYI:
I have incorporated the same changes (+ additional fixes) from this PR in my PR as well:
#2107

626bcae

@WikiRik
Copy link
Member

WikiRik commented Jan 30, 2023

@pano9000 I assume we can close this now #2107 has been merged?

@pano9000
Copy link
Contributor

closing the PR as its changes were merged as part of the bigger #2107 / 0586d23
@WikiRik thanks for reminding me
@ademyan05 thank you for the PR and sorry for having to close this one!

@pano9000 pano9000 closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants