Skip to content

VALI-5458 :: Add Client Scripts Python Packages #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 10, 2023
Merged

VALI-5458 :: Add Client Scripts Python Packages #49

merged 5 commits into from
May 10, 2023

Conversation

ricardo-dematos
Copy link
Contributor

@ricardo-dematos ricardo-dematos commented Feb 1, 2023 •
edited
Loading

Requested Python packages added.

Commits
  • 101a9f8 Requested Python packages added

More details about this issue at VALI-5458 — Jira

@ricardo-dematos ricardo-dematos self-assigned this Feb 1, 2023
@ricardo-dematos ricardo-dematos added dependencies Pull requests that update a dependencies file python Pull requests that update python code labels Feb 1, 2023
@ricardo-dematos ricardo-dematos marked this pull request as ready for review February 1, 2023 21:14
goncalo-dias-altium
goncalo-dias-altium reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@goncalo-dias-altium goncalo-dias-altium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these jira and slack packages really needed?

@ricardo-dematos
Copy link
Contributor Author

ricardo-dematos commented Feb 10, 2023 •
edited by joaofogoncalves
Loading

are these jira and slack packages really needed?

According to VALI-5458 , they were requested by --redacted--.

@antonio-valispace can you provide more context, please?

@ricardo-dematos ricardo-dematos force-pushed the VALI-5458-add-client-scripts-python-packages branch from 27e3d72 to d904b47 Compare February 10, 2023 00:56
@github-actions
Copy link
Contributor

Pull Request is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added the stale Pull requests that are stale label Feb 24, 2023
@ricardo-dematos ricardo-dematos added stale-exempt Pull requests exempt from stale and removed stale Pull requests that are stale labels Feb 24, 2023
@joaofogoncalves
Copy link
Contributor

joaofogoncalves commented May 10, 2023 •
edited
Loading

For reference these are the added libs:

@joaofogoncalves joaofogoncalves merged commit 2de37ae into develop May 10, 2023
@joaofogoncalves joaofogoncalves deleted the VALI-5458-add-client-scripts-python-packages branch May 10, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaofogoncalves joaofogoncalves Awaiting requested review from joaofogoncalves

1 more reviewer

@goncalo-dias-altium goncalo-dias-altium goncalo-dias-altium left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ricardo-dematos ricardo-dematos

Labels

dependencies Pull requests that update a dependencies file python Pull requests that update python code stale-exempt Pull requests exempt from stale

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ricardo-dematos @joaofogoncalves @goncalo-dias-altium