Skip to content

Correctly set the source repository when doing PR validation #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Correctly set the source repository when doing PR validation #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/zola-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ jobs:
ref: >-
${{ github.event_name == 'pull_request' &&
github.head_ref || 'main' }}
repository: >-
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels ugly, but I'm not entirely sure exactly what is the more correct way to do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are github actions supposed to be pretty? If it works, I'm not opposed

${{ github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name || 'main' }}
path: website

- name: Checkout valkey-doc
Expand Down