Skip to content

Update website for version 9.0.0-rc1 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

Conversation

madolson
Copy link
Member

This pull request updates the downloads page of the valkey website with the new release 9.0.0-rc1.
Please review the changes and merge when appropriate.

@madolson madolson requested a review from stockholmux as a code owner August 14, 2025 19:55
Copy link
Member

@Nikhil-Manglore Nikhil-Manglore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stockholmux
Copy link
Member

Do we want rc1 on the website?

@Nikhil-Manglore
Copy link
Member

If i'm not mistaken I think we did in the past for release candidates? Not 100% sure though

@stockholmux
Copy link
Member

stockholmux commented Aug 14, 2025

We did @Nikhil-Manglore, but as per #211 the web page was mutable (e.g. one day v8-0-0 had rc then it had GA the next day) that wasn't desired. This PR makes it so that RC will have it's own page. We need to update the automation to fix this for subsequent releases though.

@Nikhil-Manglore
Copy link
Member

Ok I will open a PR in the release repo to address this for future releases.

@stockholmux
Copy link
Member

We should double check if that's what @madolson and @ranshid really wanted.

The RC will be at: /download/releases/v9-0-0-rc1/ and GA would be at /download/releases/v9-0-0

This is what it looks like

Screenshot 2025-08-14 at 2 34 24 PM

@madolson
Copy link
Member Author

madolson commented Aug 14, 2025

Yeah, my recollection is we wanted immutable pages but only show the latest RC link in various places.

@Nikhil-Manglore
Copy link
Member

Makes sense, I'll update the automation to do this in the future

@stockholmux stockholmux mentioned this pull request Aug 15, 2025
1 task
### Description

As per #211, this will make sure that there is a release page for `rc1`
distinct from GA and other release candidates.
### Issues Resolved

(this doesn't solve 211 - that will need to be fixed in the release
automation)

### Check List
- [x] Commits are signed per the DCO using `--signoff`

By submitting this pull request, I confirm that my contribution is made
under the terms of the BSD-3-Clause License.

Signed-off-by: Kyle J. Davis <[email protected]>
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stockholmux stockholmux merged commit 2d63f74 into main Aug 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants