-
Notifications
You must be signed in to change notification settings - Fork 64
Update website for version 9.0.0-rc1 #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we want rc1 on the website? |
If i'm not mistaken I think we did in the past for release candidates? Not 100% sure though |
We did @Nikhil-Manglore, but as per #211 the web page was mutable (e.g. one day v8-0-0 had rc then it had GA the next day) that wasn't desired. This PR makes it so that RC will have it's own page. We need to update the automation to fix this for subsequent releases though. |
Ok I will open a PR in the release repo to address this for future releases. |
Yeah, my recollection is we wanted immutable pages but only show the latest RC link in various places. |
Makes sense, I'll update the automation to do this in the future |
### Description As per #211, this will make sure that there is a release page for `rc1` distinct from GA and other release candidates. ### Issues Resolved (this doesn't solve 211 - that will need to be fixed in the release automation) ### Check List - [x] Commits are signed per the DCO using `--signoff` By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License. Signed-off-by: Kyle J. Davis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This pull request updates the downloads page of the valkey website with the new release 9.0.0-rc1.
Please review the changes and merge when appropriate.