Skip to content

Move vavr.control.Try,vavr.control.Either,vavr.control.Option to vavr package. #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
He-Pin opened this issue Nov 24, 2018 · 6 comments
Closed
Labels

Comments

@He-Pin
Copy link

He-Pin commented Nov 24, 2018

refs:scala/bug#11268

@danieldietrich
Copy link
Contributor

Thanks for the suggestion.
Moving things around might be 'foolish consistency'. It will break code out there.
The only benefit is grouping things that belong together - we already do that!
Is it worth to break existing applications? (I don't think so)

When will Scala move Try and Either?

@He-Pin
Copy link
Author

He-Pin commented Dec 9, 2018

@danieldietrich I think they will move it in 2.14, it's planed in 2.13 but you know:)

@danieldietrich
Copy link
Contributor

The difference between Vavr and Scala is that scala have different packages for Option, Either and Try (scala and scala.util) and we have one package (io.vavr.control).

Do you think it is worth to break backeard compatibility, by moving Option, Try and Either to io.vavr?

I agree that these are our most basic types.

@He-Pin
Copy link
Author

He-Pin commented Dec 9, 2018

I can only say if that will be done, they should be done in 1.0, as they are the most basic types:)
There is no type alias in Java so, I don't know.

@danieldietrich
Copy link
Contributor

Moving them from io.vavr.control to io.vavr will lock us forever from shipping controls as a separate module.

I will think about it. It is not the most important task for now. I will focus on the collection interfaces next. We will decide it until 1.0 final.

@He-Pin
Copy link
Author

He-Pin commented Dec 17, 2018

@danieldietrich FYI: scala/scala#7425 ,I think this should be done in 1.0 if you decided to .

@He-Pin He-Pin closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants