simplified git config causes remote upstream rewrite on every run

[aschleifer]

If I use a simple config entry like:

~/test/cvspull:
  mypackage: 'git+ssh://git@gitlab.com/mygroup/mypackage.git'

I always see the line about Updating remote origin:

Updating remote origin (ssh://git@gitlab.com/mygroup/mypackage.git) with git+ssh://git@gitlab.com/mygroup/mypackage.git

which then in turn causes a retry of the update.

To fix this issue I have to use a config like this:

~/test/cvspull:
  mypackage:
    url: 'git+ssh://git@gitlab.com/mygroup/mypackage.git'
    remotes:
      origin: 'ssh://git@gitlab.com/mygroup/mypackage.git'

This then works, but I would like to have a more compact/simplified config with only one line per repo.

(repogroup and name have been abstracted, as the used gitlab is internal ;) )

Best regards
Segaja

[tony]

@aschleifer Thank you, good catch!

If you want to start a pull request you are welcome. If not I will hopefully get around to it soon - I've also been getting it

[aschleifer]

I don't think I'm deep enough in the code to easily do it right now and my python is a bit rusty.

[tony]

@aschleifer No problem, it's about time I give a tests a top-down review

[aschleifer]

@tony once this bug is fixed I'm happy to fix the new scripts to use the simplified configuration again. But you can also do it in the same PR where you fix this.

[aschleifer]

@tony just a headsup: since now the new structure is in, i will wait for this fix before i look at the add command and into moving the gitlab generator script into the actual package.

[tony]

@aschleifer Noted, and looking into this during the weekend

[tony]

@aschleifer Fix is still a WIP

Will continue next weekend

After this issue and #338 is fixed, will move onto making libvcs and vcspull easier to read. I originally started this 8 years ago when totally new at python.