Fix build on macOS Catalina #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Rodin <[email protected]>
ghost
force-pushed
the
macos-catalina-fix
branch
from
0062781 to
924c52b
Compare
ghost
pushed a commit
that referenced
this pull request
Oct 22, 2019
This reverts commit 9cb0245. Signed-off-by: Alexander Rodin <[email protected]>
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 22, 2019
* Avoid use of undefined std::process::Command behavior std::process::Command is known to be unpredictable when a relative path is used together with `current_dir`, and outright fails on macOS Catalina [0]. Absolutize paths before passing them to std::process::Command to stay within the documented constraints of the API. [0]: rust-lang/rust#37868 * Revert "Fix build on macOS Catalina (#1)" This reverts commit 9cb0245. Signed-off-by: Alexander Rodin <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Oct 22, 2019
Signed-off-by: Alexander Rodin <[email protected]>
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref vectordotdev/vector#1032.