Skip to content

Conversation

JakubOnderka
Copy link
Contributor

Summary

zlib-rs is much faster for library for zlib decoding/encoding than default miniz_oxide and it is even faster than zlib-ng (https://trifectatech.org/blog/zlib-rs-is-faster-than-c/).

Previous pull request #1301 breaks vector build, so it was reverted in #1366. But now it should be fixed in zlib-rs version 0.5.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Standard tests.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

@pront
Copy link
Member

pront commented Apr 8, 2025

Check passed: https://github.com/vectordotdev/vector/actions/runs/14312253986
Will merge now.

@pront pront enabled auto-merge April 8, 2025 14:56
@pront pront added this pull request to the merge queue Apr 8, 2025
Merged via the queue into vectordotdev:main with commit d802b30 Apr 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants