Add missing i18n types in gip context #25363

rokinsky · 2021-05-22T15:50:20Z

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

[] Make sure the linting passes

Ref: #21930

ijjk · 2021-05-22T16:03:08Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
buildDuration	15.9s	15.9s	-36ms
buildDurationCached	4.5s	4.3s	-166ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +431 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.846	2.845	0
/ avg req/sec	878.31	878.85	+0.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.652	1.762	⚠️ +0.11
/error-in-render avg req/sec	1513.44	1418.45	⚠️ -94.99

Client Bundles (main, webpack, commons)

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
index.html gzip	559 B	559 B	✓
link.html gzip	567 B	567 B	✓
withRouter.html gzip	555 B	555 B	✓
Overall change	1.68 kB	1.68 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
buildDuration	18.2s	18.2s	⚠️ +26ms
buildDurationCached	5.5s	5.5s	-72ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +431 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	2.42 kB	2.42 kB	✓
500.html	2.41 kB	2.41 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.61 kB	1.61 kB	✓
css.html	1.79 kB	1.79 kB	✓
hooks.html	1.67 kB	1.67 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
buildDuration	14.1s	13.8s	-320ms
buildDurationCached	5.9s	5.7s	-172ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +431 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.94	2.794	-0.15
/ avg req/sec	850.28	894.84	+44.56
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.697	1.681	-0.02
/error-in-render avg req/sec	1472.89	1486.84	+13.95

Client Bundles (main, webpack, commons)

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.25 kB	7.25 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.38 kB	9.38 kB	✓

Client Build Manifests

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	rokinsky/next.js buxfix/gip-i18n-types	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: c7d4b5e

timneutkens

Can you add an integration test to test/integration/typescript?

rokinsky · 2021-05-22T16:38:58Z

Can you add an integration test to test/integration/typescript?

@timneutkens I'll try to add the test next week

rokinsky · 2021-05-28T22:24:06Z

Hi, @timneutkens. In my opinion, test/integration/typescript is not the right place for this, so we have to create a separate test/integration/typescript-i18n where we should check the SSG, SSR, GiP, and router for i18n types. What do you think?

timneutkens · 2021-05-30T04:14:45Z

Sounds fine 👍

## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [] Make sure the linting passes Ref: vercel#21930

fix(types): add i18n types to gip context

c7d4b5e

rokinsky requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners May 22, 2021 15:50

ijjk added the type: next label May 22, 2021

rokinsky mentioned this pull request May 22, 2021

I18n context initial props #21930

Merged

timneutkens approved these changes May 22, 2021

View reviewed changes

kodiakhq bot merged commit 48cbb81 into vercel:canary May 22, 2021

rokinsky deleted the buxfix/gip-i18n-types branch May 22, 2021 16:39

sync-by-unito bot mentioned this pull request May 26, 2021

chore(deps): bump next from 10.0.7 to 10.2.3 filecoin-project/slate#766

Closed

This was referenced Jul 29, 2021

[Snyk] Upgrade next from 10.0.3 to 10.2.3 bgeveritt-snyk/next.js#9

Open

[Snyk] Upgrade next from 10.0.7 to 10.2.3 bgeveritt-snyk/next.js#21

Open

snyk-bot mentioned this pull request Oct 19, 2021

[Snyk] Upgrade next from 10.0.8 to 10.2.3 orysmudi/next.js#2

Open

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add missing i18n types in gip context #25363

Add missing i18n types in gip context #25363

Uh oh!

rokinsky commented May 22, 2021 •

edited

Loading

Uh oh!

ijjk commented May 22, 2021

Uh oh!

timneutkens left a comment •

edited

Loading

Uh oh!

rokinsky commented May 22, 2021

Uh oh!

rokinsky commented May 28, 2021

Uh oh!

timneutkens commented May 30, 2021

Uh oh!

Uh oh!

Add missing i18n types in gip context #25363

Add missing i18n types in gip context #25363

Uh oh!

Conversation

rokinsky commented May 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug

Feature

Documentation / Examples

Uh oh!

ijjk commented May 22, 2021

Stats from current PR

Uh oh!

timneutkens left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rokinsky commented May 22, 2021

Uh oh!

rokinsky commented May 28, 2021

Uh oh!

timneutkens commented May 30, 2021

Uh oh!

Uh oh!

rokinsky commented May 22, 2021 •

edited

Loading

timneutkens left a comment •

edited

Loading