Skip to content

Conversation

borekb
Copy link
Contributor

@borekb borekb commented Jul 8, 2021

Fixes a small issue introduced in 3cd4f34 / #26573 (released in v11.0.2-canary.1 I believe; never getting to stable).

Running next build produces a changed file:

Screen Shot 2021-07-08 at 23 13 35

This conflicts with our Prettier setup and a pre-commit hook, I have to add the trailing new line (\n, os.EOL) back, another next build will rewrite it again, etc.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@borekb
Copy link
Contributor Author

borekb commented Jul 8, 2021

@styfle You're too fast 😄. I was trying to contribute from the new "Remote Repositories" feature of VSCode which didn't allow me to write a PR description, which I'm going to fix shortly.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jul 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary borekb/next.js add-newline-next-env Change
buildDuration 14s 14s ⚠️ +7ms
buildDurationCached 3.3s 3.2s -93ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +49 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary borekb/next.js add-newline-next-env Change
/ failed reqs 0 0
/ total time (seconds) 2.314 2.341 ⚠️ +0.03
/ avg req/sec 1080.19 1067.76 ⚠️ -12.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.266 1.281 ⚠️ +0.01
/error-in-render avg req/sec 1974.99 1952.12 ⚠️ -22.87
Client Bundles (main, webpack, commons)
vercel/next.js canary borekb/next.js add-newline-next-env Change
359.HASH.js gzip 3.09 kB 3.09 kB
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.6 kB 20.6 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary borekb/next.js add-newline-next-env Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary borekb/next.js add-newline-next-env Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.69 kB 5.69 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary borekb/next.js add-newline-next-env Change
_buildManifest.js gzip 419 B 419 B
Overall change 419 B 419 B
Rendered Page Sizes
vercel/next.js canary borekb/next.js add-newline-next-env Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode
General Overall increase ⚠️
vercel/next.js canary borekb/next.js add-newline-next-env Change
buildDuration 11.2s 11.3s ⚠️ +79ms
buildDurationCached 4.5s 4.4s -50ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +49 B
Page Load Tests Overall increase ✓
vercel/next.js canary borekb/next.js add-newline-next-env Change
/ failed reqs 0 0
/ total time (seconds) 2.3 2.354 ⚠️ +0.05
/ avg req/sec 1086.91 1062.25 ⚠️ -24.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.285 1.267 -0.02
/error-in-render avg req/sec 1945.33 1972.83 +27.5
Client Bundles (main, webpack, commons)
vercel/next.js canary borekb/next.js add-newline-next-env Change
14.HASH.js gzip 3.11 kB 3.11 kB
677f882d2ed8..HASH.js gzip 13.9 kB 13.9 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 7.81 kB 7.81 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary borekb/next.js add-newline-next-env Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary borekb/next.js add-newline-next-env Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.83 kB 3.83 kB
amp-HASH.js gzip 531 B 531 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 230 B 230 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 297 B 297 B
withRouter-HASH.js gzip 293 B 293 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 8.98 kB 8.98 kB
Client Build Manifests
vercel/next.js canary borekb/next.js add-newline-next-env Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes
vercel/next.js canary borekb/next.js add-newline-next-env Change
index.html gzip 574 B 574 B
link.html gzip 586 B 586 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 34b0b15

@ijjk
Copy link
Member

ijjk commented Jul 9, 2021

Failing test suites

Commit: 34b0b15

test/integration/route-load-cancel/test/index.test.js

  • next/dynamic > dev mode > should cancel slow page loads on re-navigation
Expand output

● next/dynamic › dev mode › should cancel slow page loads on re-navigation

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#page-text"}
  (Session info: headless chrome=91.0.4472.114)

  31 |     await waitFor(1000)
  32 |
> 33 |     const text = await browser.elementByCss('#page-text').text()
     |                  ^
  34 |     expect(text).toMatch(/2/)
  35 |     expect(await browser.eval('window.routeCancelled')).toBe('yes')
  36 |   })

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/route-load-cancel/test/index.test.js:33:18)

@ijjk ijjk merged commit d60c95c into vercel:canary Jul 9, 2021
@borekb borekb deleted the add-newline-next-env branch July 9, 2021 06:50
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants