Skip to content

#4751 - Explicitly mention install when cloning examples #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2018
Merged

#4751 - Explicitly mention install when cloning examples #4758

merged 4 commits into from
Jul 11, 2018

Conversation

michaeljonathanblack
Copy link

@michaeljonathanblack michaeljonathanblack commented Jul 10, 2018

Preferably this installation wouldn't be necessary, but in lieu of a fix...

#4751

@timneutkens
Copy link
Member

I don't think we should mention cloning the repository in the examples, as there's no real reason to do that, cloning over 100 examples + next.js source to boot up 1 example. So I'd like to remove all those mentions instead of updating them.

@michaeljonathanblack
Copy link
Author

Ready for review

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆💯Great PR 🙏

@timneutkens timneutkens merged commit 5b3578e into vercel:canary Jul 11, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants