Revert "build(edge): extract buildId into environment" #65425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce99c61.
ijjk
requested review from
timneutkens,
shuding,
huozhi,
a team,
ztanner,
feedthejim and
wyattjoh
as code owners
|
Issue reopened: NEXT-3117 build(edge): extract buildId into environment |
ijjk
added
created-by: Next.js team
huozhi
approved these changes
May 6, 2024
huozhi
added a commit
that referenced
this pull request
May 8, 2024
### What * Extract `buildId` and server action encryption key into environment variables for edge to make code more deterministic * Fixed the legacy bad env names from #64108 * Always sort `routes` in prerender manifest for consistent output * Change `environments` to `env` in middleware manifest, confirmed with @javivelasco this is a fine change without need to bumping the version ### Why Dynamic variants like `buildId`, SA `encryptionKey` and preview props are different per build, which results to the non determinstic edge bundles. Once we extracted them into env vars then the bundles become deterministic which give us more space for optimization Closes NEXT-3117 Reverts #65425 Co-authored-by: Jiachi Liu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to hold until upstream roll-out
Reverts #64521
Closes NEXT-3343