Add checking of react versions #6892

ijjk · 2019-04-04T16:12:13Z

Since a user can run into errors if they are not using a version of react specified in our peerDependencies we add a check to make sure they are and if not show an error.

meets the minimum set in peerDependencies

github-actions · 2019-04-04T16:18:30Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	14.1s	13.3s	-896ms
`node_modules` Size	43.9 MB	44 MB	⚠️ +4.66 kB
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Base Rendered Size	1.32 kB	1.32 kB	✓
Build Dir Size	345 kB	345 kB	✓

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	18.1s	18s	-134ms
`node_modules` Size	43.9 MB	44 MB	⚠️ +4.66 kB
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Serverless `pages/link` Size	225 kB	225 kB	✓
Serverless `pages/link` gzip Size	59.1 kB	59.1 kB	⚠️ +3 B
Serverless `pages/index` Size	220 kB	220 kB	✓
Serverless `pages/index` gzip Size	57.9 kB	57.9 kB	⚠️ +5 B
Serverless `pages/_error` Size	222 kB	222 kB	✓
Serverless `pages/_error` gzip Size	57.9 kB	57.9 kB	⚠️ +3 B
Serverless `pages/routerDirect` Size	221 kB	221 kB	✓
Serverless `pages/routerDirect` gzip Size	57.9 kB	58 kB	⚠️ +4 B
Serverless `pages/withRouter` Size	221 kB	221 kB	✓
Serverless `pages/withRouter` gzip Size	58 kB	58 kB	⚠️ +6 B
Build Dir Size	1.33 MB	1.33 MB	✓

timneutkens · 2019-04-04T20:28:24Z

No need to make this overly complex, you can do something like this:

const React = require('react')

if(typeof React.Suspense === 'undefined') {
  throw new Error('please upgrade React (etc, just a quick example')
}

…-check

github-actions · 2019-04-04T21:09:58Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	13.5s	13s	-544ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +829 B
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Base Rendered Size	1.32 kB	1.32 kB	✓
Build Dir Size	345 kB	345 kB	✓

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	17s	17s	⚠️ +18ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +829 B
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Serverless `pages/link` Size	225 kB	225 kB	✓
Serverless `pages/link` gzip Size	59 kB	59 kB	⚠️ +1 B
Serverless `pages/index` Size	220 kB	220 kB	✓
Serverless `pages/index` gzip Size	57.8 kB	57.8 kB	-1 B
Serverless `pages/_error` Size	222 kB	222 kB	✓
Serverless `pages/_error` gzip Size	57.8 kB	57.8 kB	✓
Serverless `pages/routerDirect` Size	221 kB	221 kB	✓
Serverless `pages/routerDirect` gzip Size	57.8 kB	57.8 kB	-1 B
Serverless `pages/withRouter` Size	221 kB	221 kB	✓
Serverless `pages/withRouter` gzip Size	57.9 kB	57.9 kB	✓
Build Dir Size	1.33 MB	1.33 MB	✓

packages/next/bin/next.ts

Co-Authored-By: ijjk <[email protected]>

github-actions · 2019-04-04T21:33:47Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	13.8s	13.2s	-622ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +832 B
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Base Rendered Size	1.32 kB	1.32 kB	✓
Build Dir Size	345 kB	345 kB	✓

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	17.2s	16.9s	-294ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +832 B
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Serverless `pages/link` Size	225 kB	225 kB	✓
Serverless `pages/link` gzip Size	59 kB	59 kB	✓
Serverless `pages/index` Size	220 kB	220 kB	✓
Serverless `pages/index` gzip Size	57.8 kB	57.8 kB	-4 B
Serverless `pages/_error` Size	222 kB	222 kB	✓
Serverless `pages/_error` gzip Size	57.8 kB	57.8 kB	✓
Serverless `pages/routerDirect` Size	221 kB	221 kB	✓
Serverless `pages/routerDirect` gzip Size	57.8 kB	57.8 kB	-3 B
Serverless `pages/withRouter` Size	221 kB	221 kB	✓
Serverless `pages/withRouter` gzip Size	57.9 kB	57.9 kB	-4 B
Build Dir Size	1.33 MB	1.33 MB	✓

github-actions · 2019-04-04T21:39:14Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	14s	13.1s	-910ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +982 B
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Base Rendered Size	1.32 kB	1.32 kB	✓
Build Dir Size	345 kB	345 kB	✓

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	17.4s	17s	-433ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +982 B
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Serverless `pages/link` Size	225 kB	225 kB	✓
Serverless `pages/link` gzip Size	59 kB	59 kB	⚠️ +1 B
Serverless `pages/index` Size	220 kB	220 kB	✓
Serverless `pages/index` gzip Size	57.8 kB	57.8 kB	⚠️ +1 B
Serverless `pages/_error` Size	222 kB	222 kB	✓
Serverless `pages/_error` gzip Size	57.8 kB	57.8 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	221 kB	221 kB	✓
Serverless `pages/routerDirect` gzip Size	57.8 kB	57.8 kB	✓
Serverless `pages/withRouter` Size	221 kB	221 kB	✓
Serverless `pages/withRouter` gzip Size	57.9 kB	57.9 kB	✓
Build Dir Size	1.33 MB	1.33 MB	✓

github-actions · 2019-04-04T21:44:46Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	13.7s	13.7s	⚠️ +39ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +1.64 kB
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Base Rendered Size	1.32 kB	1.32 kB	✓
Build Dir Size	345 kB	345 kB	✓

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js add/react-version-check	Change
Build Duration	17.8s	17s	-785ms
`node_modules` Size	43.9 MB	43.9 MB	⚠️ +1.64 kB
Total Bundle (main, webpack, commons) Size	208 kB	208 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.1 kB	68.1 kB	✓
Client `_app` Size	2.49 kB	2.49 kB	✓
Client `_app` gzip Size	1.04 kB	1.04 kB	✓
Client `_error` Size	8.85 kB	8.85 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	298 B	298 B	✓
Client `pages/index` gzip Size	235 B	235 B	✓
Client `pages/link` Size	3.28 kB	3.28 kB	✓
Client `pages/link` gzip Size	1.49 kB	1.49 kB	✓
Client `pages/routerDirect` Size	426 B	426 B	✓
Client `pages/routerDirect` gzip Size	304 B	304 B	✓
Client `pages/withRouter` Size	408 B	408 B	✓
Client `pages/withRouter` gzip Size	293 B	293 B	✓
Client `main` Size	22.8 kB	22.8 kB	✓
Client `main` gzip Size	7.37 kB	7.37 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.5 kB	59.5 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	774 B	774 B	✓
Serverless `pages/link` Size	225 kB	225 kB	✓
Serverless `pages/link` gzip Size	59 kB	59 kB	✓
Serverless `pages/index` Size	220 kB	220 kB	✓
Serverless `pages/index` gzip Size	57.8 kB	57.8 kB	✓
Serverless `pages/_error` Size	222 kB	222 kB	✓
Serverless `pages/_error` gzip Size	57.8 kB	57.8 kB	-1 B
Serverless `pages/routerDirect` Size	221 kB	221 kB	✓
Serverless `pages/routerDirect` gzip Size	57.8 kB	57.8 kB	✓
Serverless `pages/withRouter` Size	221 kB	221 kB	✓
Serverless `pages/withRouter` gzip Size	57.9 kB	57.9 kB	✓
Build Dir Size	1.33 MB	1.33 MB	✓

Add checking of react versions to make sure it

42571a2

meets the minimum set in peerDependencies

ijjk requested review from dav-is, lfades, Timer and timneutkens as code owners April 4, 2019 16:12

ijjk added 2 commits April 4, 2019 15:38

Merge remote-tracking branch 'upstream/canary' into add/react-version…

5b5d461

…-check

Simplify react check

82837ca

timneutkens reviewed Apr 4, 2019

View reviewed changes

packages/next/bin/next.ts Outdated Show resolved Hide resolved

Update error wording

fb2f9ce

Co-Authored-By: ijjk <[email protected]>

timneutkens approved these changes Apr 4, 2019

View reviewed changes

ijjk added 2 commits April 4, 2019 16:32

Add err.sh

7a1b11c

Update test-production circleci job name

bc6998f

Add react error message to next-dev-server

5393356

Update test for new wording

04b41b8

ijjk merged commit 9995f5d into vercel:canary Apr 4, 2019

ijjk deleted the add/react-version-check branch April 4, 2019 21:47

jaycenhorton mentioned this pull request Apr 27, 2019

@material-ui/core incompatible with next.js mui/material-ui#15505

Closed

2 tasks

lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add checking of react versions #6892

Add checking of react versions #6892

Uh oh!

ijjk commented Apr 4, 2019

Uh oh!

github-actions bot commented Apr 4, 2019

Uh oh!

timneutkens commented Apr 4, 2019 •

edited

Loading

Uh oh!

github-actions bot commented Apr 4, 2019

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2019

Uh oh!

github-actions bot commented Apr 4, 2019

Uh oh!

github-actions bot commented Apr 4, 2019

Uh oh!

Uh oh!

Add checking of react versions #6892

Add checking of react versions #6892

Uh oh!

Conversation

ijjk commented Apr 4, 2019

Uh oh!

github-actions bot commented Apr 4, 2019

Stats from current PR

Uh oh!

timneutkens commented Apr 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2019

Stats from current PR

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2019

Stats from current PR

Uh oh!

github-actions bot commented Apr 4, 2019

Stats from current PR

Uh oh!

github-actions bot commented Apr 4, 2019

Stats from current PR

Uh oh!

Uh oh!

timneutkens commented Apr 4, 2019 •

edited

Loading