Skip to content

Fixes broken UI #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fixes broken UI #86

merged 1 commit into from
Oct 17, 2023

Conversation

commitsovercoffee
Copy link
Contributor

@commitsovercoffee commitsovercoffee commented Aug 25, 2023

Updated !

Fixes #85 by adding style="margin:0" to misaligned headings.

  • Aligns waste properties & icon under Types of waste on cd workshop page.
Before After
waste-before waste-after
Before After
before-stage after-stage
  • Aligns continuous delivery principle label and > icon on cd workshop page.
Before After
cd-before cd-after
  • Fixes gap between project description and topics on projects page.
Before After
projects-before projects-after

@jlarfors
Copy link
Contributor

@commitsovercoffee thanks for the PR! That's awesome :)

I left some comments for you, would be great if you could take a look and let me know what you think.
Also if you could rebase your commits after any further changes to keep the history clean that would be much appreciated!

@commitsovercoffee
Copy link
Contributor Author

@jlarfors I have responded to your comments and reverted back to using h1-4 elements.

Tailwind's default typography style adds a top margin for h1-4 which is causing the misalignment. But I'm not sure how changing the default style for h1-h4 will affect other places where headings are used. So I have just adjusted the padding to fix the alignments. 🤔

@jlarfors
Copy link
Contributor

@commitsovercoffee thanks for the updated PR!

Did you have any objections to just adding style="margin:0" to the elements? This would remove all the margin from the headers, as added by the tailwind typography plugin, and mean we don't need to start messing around with the paddings (I'd need to test those on different screens to make sure it's responsive).

@commitsovercoffee
Copy link
Contributor Author

commitsovercoffee commented Aug 31, 2023

Did you have any objections to just adding style="margin:0" to the elements?

I had tried m-0 and that didn't work so I started looking elsewhere. I literally forgot I could do this. 🤦

@jlarfors I have updated it to style="margin:0" instead. 😬

@jlarfors jlarfors merged commit 575898e into verifa:main Oct 17, 2023
@jlarfors
Copy link
Contributor

@commitsovercoffee really sorry for the delay getting this merged. Really appreciate your contribution, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text misaligned for Value Stream wastes
2 participants