-
Notifications
You must be signed in to change notification settings - Fork 4
Fixes broken UI #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes broken UI #86
Conversation
@commitsovercoffee thanks for the PR! That's awesome :) I left some comments for you, would be great if you could take a look and let me know what you think. |
@jlarfors I have responded to your comments and reverted back to using h1-4 elements. Tailwind's default typography style adds a top margin for h1-4 which is causing the misalignment. But I'm not sure how changing the default style for h1-h4 will affect other places where headings are used. So I have just adjusted the padding to fix the alignments. 🤔 |
@commitsovercoffee thanks for the updated PR! Did you have any objections to just adding |
I had tried @jlarfors I have updated it to |
@commitsovercoffee really sorry for the delay getting this merged. Really appreciate your contribution, thanks! |
Updated !
Fixes #85 by adding
style="margin:0"
to misaligned headings.