Skip to content

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented May 19, 2021

@yihong0618
Copy link
Contributor Author

#104

README.md Outdated
- future
- six
- httplib2
- futures # python2.x is needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 57-61 can be deleted, directly to use requirements.txt is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@laura-ding
Copy link
Contributor

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

@yihong0618
Copy link
Contributor Author

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

Got it

@yihong0618
Copy link
Contributor Author

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

FYI

Its strange that 3.7 passed sometimes 3.6 failed

image

@laura-ding
Copy link
Contributor

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

FYI

Its strange that 3.7 passed sometimes 3.6 failed

image

because the leader of metad is changed. The randomly selected Meta happens to be the leader, so it succeeds

Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@laura-ding laura-ding changed the title feat for #105 Add requirements.txt May 20, 2021
@laura-ding laura-ding merged commit e3e6e7a into vesoft-inc:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] add requirements.txt and cache the pip requirements in Actions

2 participants