ListMachineSummaries - Add DNS names to Part summaries #745
Conversation
proto/viam/app/v1/app.proto
Outdated
| @@ -1160,6 +1160,7 @@ message LocationSummary { | |||
| message MachineSummary { | |||
| string machine_id = 1; | |||
| string machine_name = 2; | |||
| optional string main_part_dns_name = 4; | |||
There was a problem hiding this comment.
i think it makes sense to surface here, but then we should also add main_part_name here as well
There was a problem hiding this comment.
Does main_part_name mean the thing one would use to dial? Is main_part_dial_name perhaps better? I feel that a "name" could be anything and we want to be clear if the string is meant to plug into something specific.
There was a problem hiding this comment.
Adding the main part name feels wrong. We could add the main part ID if needed
Or we can just add a is_main_part boolean on the PartSummary
There was a problem hiding this comment.
@dgottlieb main_part_dns_name was intended to be the string you use to dial. We have a dns_name on the Part proto struct.
I am open to alternative names:
main_part_hostnamemain_part_urlmain_part_dial_name
There was a problem hiding this comment.
with is_main_part I don't think we need to add main_part_dns_name. tho not sure how users are most likely to want this data
NickPPC
changed the title
NickPPC
added
the
ready-for-protos
NickPPC
removed
the
ready-for-protos
https://viam.atlassian.net/browse/APP-9174