Skip to content

DATA-4319: Added Datasetids as Input to data_client #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

DATA-4319: Added Datasetids as Input to data_client #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9baa3a8
added datasetids as input to data_client
etai-shuchatowitz Aug 20, 2025
0bedc3e
lint
etai-shuchatowitz Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/app/data-client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,6 +1344,7 @@ describe('DataSyncClient tests', () => {
const methodName = 'testMethodName';
const fileExtension = '.png';
const tags = ['testTag1', 'testTag2'];
const datasetIds = ['dataset1', 'dataset2'];
const timeRequested1 = new Date(1970, 1, 1, 1, 1, 1);
const timeReceived1 = new Date(1971, 2, 2, 2, 2, 2);
const dataRequestTimes1: [Date, Date] = [timeRequested1, timeReceived1];
Expand Down Expand Up @@ -1430,6 +1431,7 @@ describe('DataSyncClient tests', () => {
metadata.type = DataType.BINARY_SENSOR;
metadata.fileExtension = fileExtension;
expectedRequest.metadata = metadata;
expectedRequest.metadata.datasetIds = datasetIds;
const sensorData = new SensorData();
const sensorMetadata = new SensorMetadata();
sensorMetadata.timeRequested = Timestamp.fromDate(timeRequested1);
Expand All @@ -1447,7 +1449,8 @@ describe('DataSyncClient tests', () => {
methodName,
fileExtension,
dataRequestTimes1,
tags
tags,
datasetIds
);
expect(capReq).toStrictEqual(expectedRequest);
expect(response).toStrictEqual('fileId');
Expand Down
4 changes: 3 additions & 1 deletion src/app/data-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,8 @@ export class DataClient {
methodName: string,
fileExtension: string,
dataRequestTimes: [Date, Date],
tags?: string[]
tags?: string[],
datasetIds?: string[]
) {
const metadata = new UploadMetadata({
partId,
Expand All @@ -1248,6 +1249,7 @@ export class DataClient {
type: DataType.BINARY_SENSOR,
tags,
fileExtension,
datasetIds,
});

const sensorData = new SensorData({
Expand Down