-
Notifications
You must be signed in to change notification settings - Fork 47
RSDK-11706 — Update TypeScript SDK with new GetImages signature #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@stuqdog @micheal-parks @lia-viam Any ideas on how I can easily manually test this change? e.g. perhaps spin up a TS client pinned to my local feature branch ver of the SDK. I tried using the node example in this repo and failed miserably on the npm install step and am looking for easier alternatives. |
ok I added a package.json bump for the dep that was making my
to main.ts and saw
And when I got rid of the filter, it returned all images
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
RSDK-11706
Update TypeScript SDK with new GetImages signature