towards webext-js-ipfs: webpack, refactor, reorg, cleanup, update manifest #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
14 tasks
|
Thanks! Pushed some updates I've done during some nights, seems there is bunch of conflicts. I'll take a look at this later and also write an update in the |
daviddias
commented
May 9, 2017
| @@ -0,0 +1,3 @@ | |||
| # This file was created by https://github.com/mozilla/web-ext | |||
There was a problem hiding this comment.
No, this is needs to be persisted because otherwise it'll always be generated and result in a new extension instead of new version to existing one.
daviddias
commented
May 9, 2017
spawn-node.js
Outdated
| webRTCStar: { | ||
| Enabled: true | ||
| } | ||
| } |
There was a problem hiding this comment.
This doesn't apply with new version of IPFS
|
I can finish off the proposed changes here tonight |
|
@victorbjelkholm looked at all the commits and I believe they can be discarded, since in my update:
Might double check and if confirmed, discard the minor changes and merge my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@victorbjelkholm can we rename this project
webext-js-ipfsand move it to the IPFS org, please?Made this for ipfs/in-web-browsers#54