Skip to content

Error highlighting not working #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrettHemes-3M opened this issue Jun 9, 2021 · 6 comments
Closed

Error highlighting not working #48

BrettHemes-3M opened this issue Jun 9, 2021 · 6 comments
Assignees

Comments

@BrettHemes-3M
Copy link

BrettHemes-3M commented Jun 9, 2021

Moving this from discussions as I have tried again on a new fresh Ubuntu install with no other bundles with the same result...

Ubuntu 20.04
Vim 8.1.2269

I recently got a new Ubuntu 20.04 install going and am having trouble with my new Vim install in combination with vim-erlang-compiler. Long story short, syntax errors are not highlighting.

On save (:w) seemingly nothing happens. If I run :make I get good (expected) error listings and then the prompt

Press ENTER or type command to continue

after pressing Enter Vim displays at the bottom something like

"file_at_hand.erl:##" [New File]
(1 of #): error_number_1_listing
Press ENTER or type command to continue

after pressing Enter here I presented with a new buffer named file_at_hand.erl:## where ## is the line number of the first error.

Then nothing... If I close the new buffer I am back at the original file and I can edit as normal. Its like something is getting stuck as it is generating the error messages and corresponding highlighting?

@hcs42 hcs42 self-assigned this Jun 14, 2021
@hcs42
Copy link
Member

hcs42 commented Jun 14, 2021

Do you use Erlang 24?

I suspect that the Erlang compiler's output format was changed in Erlang 24, and the plugin cannot parse it.

I will check whether the plugin works with Erlang 24 on my machine, and if not, I will adjust it to work with the Erlang 24 too.

@BrettHemes-3M
Copy link
Author

Indeed, this new install is with OTP 24

hcs42 added a commit to hcs42/vim-erlang-compiler that referenced this issue Jun 20, 2021
OTP 24 modified the compiler output in two ways:

1.  The error messages include the column number. This commit extends
    the 'errorformat' option to accept column numbers.

2.  The compiler output includes the problematic part of the source code
    by default. This commit disables this behaviour.
@hcs42
Copy link
Member

hcs42 commented Jun 20, 2021

@BrettHemes

I fixed the problem in my issue_48 branch.

Could you try it?

@BrettHemes-3M
Copy link
Author

I am unsure of how to force Vundle to use a non-default branch. Do you know?

@BrettHemes-3M
Copy link
Author

OK, I was able to figure out how to test this and have confirmed it is working with my setup and OTP 24 👍

@hcs42
Copy link
Member

hcs42 commented Jul 3, 2021

Thank you. The fix is now available in the master branch too.

@hcs42 hcs42 closed this as completed Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants