Make it possible to extend code path with configurable wildcard #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a configuration variable that makes it possible to extend the code path that is used to search for modules. All the directories that matches the wildcard in the variable will be added to the code path. This option is useful when vim-erlang-omnicomplete cannot figure out where modules are based on the project structure. For example, the EMQX project (https://github.com/emqx/emqx) uses a fork of rebar3 for building which vim-erlang-omnicomplete cannot handle.
|
Thank you! (1) Would you add a type spec and a docstring to the newly introduced function? (2) Would you be up for extending https://github.com/vim-erlang/vim-erlang to test the Erlang side of the new functionality? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration variable that makes it possible to extend the code path that is used to search for modules. All the directories that matches the wildcard in the variable will be added to the code path. This option is useful when
vim-erlang-omnicompletecannot figure out where modules are based on the project structure. For example, the EMQX project (https://github.com/emqx/emqx) uses a fork of rebar3 for building whichvim-erlang-omnicompletecannot handle.