Removed premature callback #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I couldn't get this transformation to work, I never got the window context applied so I did some digging.
The callback is being called immediately with the file's default contents, for every file.
When the callback is called: 1. the contents are written to the stream, and 2. null is being written to the stream. Effectively signalling that we're done writing to it.
The callback will be called again for files that need the transformation, but since the stream has already been marked as "ended" this will have no effect.
I changed the code so that the callback is only called once.
I can see on NPM this plugin is actually used by people (200 DLs/week) but I don't get how it has ever been able to work?