Skip to content

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented May 6, 2025

Description

close vuejs/core#13260

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented May 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@585
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@585

commit: 30c5aa0

@edison1105 edison1105 marked this pull request as ready for review May 7, 2025 00:34
@sapphi-red
Copy link
Member

@edison1105
Copy link
Member Author

@sapphi-red
Thank you for your review, but they are not exactly the same.

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. You're right. Let's add a comment that this part also moves the mappings.

@sapphi-red sapphi-red added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label May 7, 2025
@sapphi-red sapphi-red merged commit 7f73970 into main May 9, 2025
11 checks passed
@sapphi-red sapphi-red deleted the edison/fix/13260 branch May 9, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source maps off when <script> doesn't contain at least one line break
2 participants