Skip to content

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 27, 2023

Description

When the CSS chunk is generated in a nested directory, the rendered asset URL was wrong when using relative base.

refs #14945
fixes #15141

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Nov 27, 2023
@patak-dev patak-dev merged commit ef403c0 into vitejs:main Nov 27, 2023
@sapphi-red sapphi-red deleted the fix/css-nested-chunk-name-relative-base-asset branch November 27, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: css p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in CSS output location

3 participants