fix: invalidate ssrError when HMR update occurs #8052
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a module is invalidated for HMR we need to also invalidate `mod.ssrError` in order to allow the module to attempt to be re-executed.
1 task
patak-dev
approved these changes
May 6, 2022
|
For future reference, this is a regression we introduced in #7177. I'll cherry-pick this one in |
patak-dev
added
regression
patak-dev
pushed a commit
that referenced
this pull request
May 11, 2022
|
@matthewp this PR has been included in [email protected] |
9 tasks
|
@patak-dev looks like I missed a spot :/. New PR to finish it up: #8124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a module is invalidated for HMR we need to also invalidate
mod.ssrErrorin order to allow the module to attempt to be re-executed.Additional context
No
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).