adding preliminary Blackwell support #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushanam
changed the title
|
Can we add a guard to make sure we don't try to build these arches on less than CUDA 12.8 something like: |
|
Probably not for this PR but we may want to compile the FA3 SM80 kernels for Blackwell https://github.com/vllm-project/flash-attention/blob/main/hopper/flash_fwd_kernel_sm80.h |
|
@LucasWilkinson added the guard, and thanks for pointing out FAv3. I will add it in a separate PR |
Thanks, LGTM now 👍 |
LucasWilkinson
added a commit
that referenced
this pull request
Mar 5, 2025
* adding priimary Blackwell support * guarding blackwell build against cuda < 12.8 Signed-off-by: Lucas Wilkinson <[email protected]>
LucasWilkinson
added a commit
that referenced
this pull request
Mar 5, 2025
* adding priimary Blackwell support * guarding blackwell build against cuda < 12.8 Signed-off-by: Lucas Wilkinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Blackwell archs and updates the CUTLASS version.